[Date Prev][Date Next] [Chronological] [Thread] [Top]

(ITS#5748) tavl_find3(root=NULL,,,) - and pcache? - undefined values

Full_Name: Hallvard B Furuseth
Version: HEAD, RE24
Submission from: (NULL) (
Submitted by: hallvard

libraries/liblutil/tavl.c:tavl_find3(NULL,,, &ret)
returns an undefined value and sets ret = undefined.

I don't know if that can happen; it would be if pcache.c:add_query() does:
        new_cached_query = find_filter( op, qbase->scopes[query->scope],
                            query->filter, first );
with qbase->scopes[query->scope] == NULL and not a substrings filter.

If nobody says anything I'll change tavl_find3(NULL,...) to return NULL
and set ret = -1.  I think a "no match" value fits better than 0 (match),
even though there are two "no match" values (<0, >0).