Re: (ITS#5369) GSSAPI support for client library

[hyc@symas.com]

kurt@OpenLDAP.org wrote:
> I note that the patch appears to be incomplete.  No gssapi.c included.

Sorry for the tardy review. The patch is also corrupted (both patches 
actually) and doesn't compile.

Note this section of the patch to cyrus.c:

+static ber_int_t
+sb_sasl_cyrus_encode(
+   struct sb_sasl_generic_data *p,
+   unsigned char *buf,
+   ber_len_t len,
+   Sockbuf_Buf *dst)
+{
+   sasl_conn_t *sasl_context = (sasl_conn_t *)p->ops_private;
+   ber_int_t ret;
+   unsigned tmpsize = dst->buf_size;
+
+   ret = sasl_encode( sasl_context, buf, len,
+              (SASL_CONST char **)&dst->buf_base,
+              &tmpsize );

-   assert( sbiod != NULL );
+   dst->buf_size = tmpsize;
+   dst->buf_end = dst->buf_

The last line appears to be truncated in both versions of the diff.

>
> -- Kurt
>
> On Feb 14, 2008, at 8:26 PM, kurt@openldap.org wrote:
>
>> You've only included one of the two required statements.  You need
>> also need to include either a copyright + license statement, or a
>> public domain release statement.  -- Kurt
>>
>> On Feb 14, 2008, at 9:12 AM, mimir@samba.org wrote:
>>
>>> --OgqxwSJOaUobr8KG
>>> Content-Type: text/plain; charset=iso-8859-2
>>> Content-Disposition: inline
>>> Content-Transfer-Encoding: quoted-printable
>>>
>>> Kurt,
>>>
>>> On Mon, Feb 11, 2008 at 09:06:19AM -0800, Kurt Zeilenga wrote:
>>>>> Full_Name: Rafal Szczesniak
>>>>> Version: HEAD
>>>>> OS: GNU/Linux
>>>>> URL: http://www.samba.org/~mimir/gssapi-head.diff
>>>> The submitted patch file does not contain (at the top of the file,
>>>> not =
>>> =20
>>>> as part of the diffs) the required notices.  Please review=20
>>>> http://www.openldap.org/devel/contributing.html and insert
>>>> appropriate=20
>>>> notices.  Also, please don't include in the diffs derived files
>>>> (e.g.,=20
>>>> configure).
>>> I've updated the patch file with necessary changes. Please take a
>>> look
>>> if it's fine now.
>>>
>>>
>>> cheers,
>>> --=20
>>> Rafal Szczesniak
>>> Samba Team member   http://www.samba.org
>>> Likewise Software   http://www.likewisesoftware.com
>>>

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/