[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5442) slapd_rq not locked before use bugfix

rein@basefarm.no wrote:

> I was seeing random failures of the test050-syncrepl-multimaster test.  One of
> the failures was that it went into a tight loop traversing a circular runqueue
> it had managed to create in slapd_rq.task_list.  It seems as this was caused by
> missing mutex locks around accesses to slapd_rq, which the patch uploaded to
> ftp://ftp.openldap.org/incoming/slapd_rq_lock.patch fixes.
> Before I applied this patch the test failed after being run a few times, with it
> it has now passed 100 times and is still counting.

locks in back-bdb/config.c should be pointless, as modifications to the 
configuration should only occur while all threads are paused.  The rest 
makes sort of sense, but I'd leave it to Howard.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Email:   pierangelo.masarati@sys-net.it