[Date Prev][Date Next]
Re: (ITS#5370) race condition in slap_op_time()
> email@example.com wrote:
>> However as far as I can tell, only the accesslog overlay uses
>> op->o_tincr, the value which needs the mutex. And accesslog
>> calls slap_op_time() itself when it needs that value.
>> So maybe we should remove the op->o_tincr field. Other calls
>> to slap_op_time() can be replaced with slap_get_time().
> Sounds like a good idea. It was somewhat redundant with the CSN counter
> (except that this was for all operations, and CSN was only for write
> operations) and it never became generally useful. (Shifted to microsecond
> timestamps in 2.4, because tincr isn't useful across multiple servers.) I
> guess it makes more sense to make it specific to accesslog.
Except that this will take a lot more restructuring in accesslog. Going with
the quick fix for now.
-- Howard Chu
Chief Architect, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/