[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5187) test020-proxycache failing in RE_2_4

rhafer@suse.de wrote:
> On Donnerstag, 8. November 2007, you wrote:
>> <quote who="Ralf Haferkamp">
>>> On Donnerstag, 8. November 2007, rhafer@suse.de wrote:
>>>> I think I found a way.
>>>> 1. The SLAPD_ABANDON/op->o_abandon part of the cleanup handler will now
>>>> only get executed if the final result for the search has not  been
>>>> received
>>>> (caching_reason == PC_IGNORE).
>>>> 2. Additionally, to add the entries to the cache, I do no longer use the
>>>> original Connection Object but create a new one
>>>> (connection_fake_init()),
>>>> because the op->o_abandon will be set for the original connection as
>>>> soon
>>>> as the client closes it.
>>>> I'll do some more testing locally an submit this to HEAD later for more
>>>> external testing.
>>> Fix submitted to HEAD. Please test (preferably on the machine that caused
>>> this
>>> test to fail most often ;) ).
>> I'll try this tonight.
>> Just to clarify, this is a fix in the code, rather than the test, which I
>> thought Howard had changed?
> Yes, it is a fix in the pcache code. The fix in the testcase was only done 
> temporarely in the RE24 branch (HEAD was not changed). I intend to remove it 
> as soon as I get positive feedback.

Trying to test in HEAD, can't cant past test008-concurrency on bdb tests.

Using ldapsearch to retrieve all the entries...
Filtering ldapsearch results...
Filtering original ldif used to create database...
Comparing filter output...
comparison failed - database was not created correctly
 >>>>> ./scripts/test008-concurrency failed (exit 1)
make[2]: *** [bdb-mod] Error 1
make[2]: Leaving directory `/anything/src/openldap/ldap/tests'
make[1]: *** [test] Error 2
make[1]: Leaving directory `/anything/src/openldap/ldap/tests'
make: *** [test] Error 2

testrun data:


Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.