[Date Prev][Date Next]
RE: (ITS#5154) Sequential binds to back-meta cause assertion failiure
> -----Original Message-----
> From: Pierangelo Masarati [mailto:firstname.lastname@example.org]
> Sent: Wednesday, September 26, 2007 2:54 PM
> To: email@example.com
> Cc: firstname.lastname@example.org
> Subject: Re: (ITS#5154) Sequential binds to back-meta cause assertion
> email@example.com wrote:
> > Full_Name: Matthew Hardin
> > Version: 2.3.38
> > OS: N/A
> > URL: ftp://ftp.openldap.org/incoming/
> > Submission from: (NULL) (188.8.131.52)
> > Multiple binds on the same connection where at least one bind ends up
> > /* FIXME: in some cases (e.g. unavailable)
> > * do not assume it's not candidate; rather
> > * mark this as an error to be eventually
> I think the "real" fix should be different: binds should always receive
> a fresh connection from meta_back_getconn(), which shouldn't be put
> into the cache at all. meta_back_bind() should cache them only in case
> of success, otherwise they should be destroyed. This would allow to
> remove the need to set a BINDING flag to guarantee connections used for
> bind are not shared.
I agree that would be a better fix.
> In the meanwhile, the solution you propose should be just fine, as it
> fills the hole occurring when a bind fails.
> I'll work at that ASAP.
Symas Corporation- The LDAP Guys