[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5134) dbconfig vs. DB_CONFIG

<quote who="Pierangelo Masarati">
> ghenry@suretecsystems.com wrote:
>>> I think the point is not what the code should (or should not) do, or
>>> whether its current behavior is correct or not; it's rather that the
>>> man
>>> page, as far as I understand it, is not clear about what the code
>>> currently does.
>> Ok, well the text should reflect what the code does. I think I'm missing
>> the  point of your question. If the text doesn't currently match what is
>> actually  happening in the code, then we fix the man page so it does.
> My point is that from that text I don't understand what the code does.
> Either it's my English (could well be), or it needs to be reworded.  I'm
> quoting here the original text:
> snip...
>        dbconfig <Berkeley-DB-setting>
>        Specify a configuration directive to be placed in the DB_CONFIG
>        file of the database directory. The dbconfig directive is  just
>        a convenience to allow all necessary configuration to be set in
>        the slapd.conf file.  The options set using this directive will
>        only  be  written to the DB_CONFIG file if no such file existed
>        at server startup time. This allows one to set  initial  values
>        without   overwriting/destroying  a  DB_CONFIG  file  that  was
>        already customized through other means.
> snip...
> So it seems to be quite clear about what's going to happen if no
> DB_CONFIG exists, but not as clear about what happens if DB_CONFIG
> already exists, apart from not getting overwritten or otherwise modified.

I read that as if there is no DB_CONFIG, one gets created from the
dbconfig directives. If there is one, dbconfig stuff gets ignored and the
DB_CONFIG file is used.

But yes, it's not clear what happens in that situation. So, I go back to
you ;-) What does the code actually do? If it does indeed ignore dbconfig
and honour DB_CONFIG then we say that.

As I read your comments, you sound like you don't know what the code does
(I don't as I haven't looked, but I'd be very surprised if you actually
don't know). So this brings me back to my first point; we make it say what
the code actually does do in the situation that there is a DB_CONFIG file
and dbconfig directives in slapd.conf or slapd.d/

Or am I being extremely stupid here?