Re: (ITS#4860) Sets' enhancement

[ando@sys-net.it]

raphael.ouazana@linagora.com wrote:

> It seems OK with HEAD, but only if I revert this patch:
> http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/sets.c.diff?r1=1.28.2.1&r2=1.28.2.2&hideattic=1&sortbydate=0&f=h
> 
> With this patch, I get a segfault.

I have just committed a cleanup of the slap_set_join() function that
should be consistent.  It should fix a leak in case of '&' on
overlapping sets, and consistently handle memory.  Can you please test
it and point out failures?  If you get any, please post the rules that
cause them, as those I could design worked fine (tested with valgrind).

> 
>> And, could you
>> document it on the FAQ, please?
> 
> Done: http://www.openldap.org/faq/data/cache/1133.html.  Does it seems
> good for you ?

Well, I'd prefer you to merge your comments with the existing, giant
one.  The contents look fine (although I'm not a native English
speaker), except for one consideration: for consistency, "/-0" should
return the DN untouched (although useless); perhaps "/-*" or something
like that could be used to explode the DN into all ancestors.

p.



Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
---------------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Email:   pierangelo.masarati@sys-net.it
---------------------------------------