[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#4930) slaptest should be quiet on success



On Fri, 2007-05-11 at 22:07 +0200, Pierangelo Masarati wrote:
> jsafranek@redhat.com wrote:
> 
> > The 'slaptest' tool is a bit verbose, it sends 'config file testing succeeded'
> > to stderr. IMHO it should do not output anything, especially to stderr, if
> > everything is all right.
> > 
> > Here is a small patch, causing the slaptest to display the aforementioned
> > message  only if -v switch is used:
>
> Your issue may make sense in some cases, but I'd rather reverse its
> logic and avoid printing any message only when explicitly requested to
> be "quiet" (e.g. adding a -Q switch?)

Why not, I have basically nothing against -Q switch, but it would
require a bit more changes in the current sources. I just needed
something quick-and-not-so-dirty.

Jan