[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#4930) slaptest should be quiet on success

jsafranek@redhat.com wrote:

> The 'slaptest' tool is a bit verbose, it sends 'config file testing succeeded'
> to stderr. IMHO it should do not output anything, especially to stderr, if
> everything is all right.
> Here is a small patch, causing the slaptest to display the aforementioned
> message  only if -v switch is used:
> Index: servers/slapd/slaptest.c
> ===================================================================
> RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/slaptest.c,v
> retrieving revision 1.9
> diff -r1.9 slaptest.c
> 107c107,108
> <       fprintf( stderr, "config file testing succeeded\n");
> ---
>>       if (verbose)
>>               fprintf( stderr, "config file testing succeeded\n");

Your issue may make sense in some cases, but I'd rather reverse its
logic and avoid printing any message only when explicitly requested to
be "quiet" (e.g. adding a -Q switch?)


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Email:   pierangelo.masarati@sys-net.it