Re: (ITS#4899) ITS4855 fix breaks 2.3.34

[hyc@symas.com]

quanah@stanford.edu wrote:
> Full_Name: Quanah Gibson-Mount
> Version: 2.3.34
> OS: Linux 2.6
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (171.66.35.82)
> 
> 
> I patched 2.3.34 with the patch in RE_23 for fixing the thread pool issue
> (ITS#4855)

So really this is a bug in RE23, not 2.3.34, yes?

> <http://www.openldap.org/devel/cvsweb.cgi/libraries/libldap_r/tpool.c.diff?r1=1.30.2.17&r2=1.30.2.18&hideattic=1&sortbydate=0&f=h>
> 
> My patch being:
> 
> ldap-uat00:/usr/local/build/PATCHES/openldap# cat ITS4855 
> --- openldap-2.3.34/libraries/libldap_r/tpool.c.orig    2007-03-26
> 15:19:56.000000000 -0700
> +++ openldap-2.3.34/libraries/libldap_r/tpool.c 2007-03-26 15:20:20.000000000
> -0700
> @@ -664,7 +664,7 @@
>         int i;
>  
>         for ( i=MAXKEYS-1; i>=0; i--) {
> -               if ( ctx[i].ltk_key )
> +               if ( ctx[i].ltk_key == NULL )
>                         continue;
>                 if ( ctx[i].ltk_free )
>                         ctx[i].ltk_free( ctx[i].ltk_key, ctx[i].ltk_data );

-- 
   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP     http://www.openldap.org/project/