[Date Prev][Date Next] [Chronological] [Thread] [Top]

(ITS#4800) ldapmodify.c:parse_ldif_control() broken

Full_Name: Hallvard B Furuseth
Version: HEAD
OS: Linux
Submission from: (NULL) (
Submitted by: hallvard

tools/ldapmodify.c:parse_ldif_control() uses variable s uninitialized -
the variable which supposedly contains the control.

Buggy since ver 1.189 Fri Nov 24 16:05:45 2006 UTC, by hyc:
  "Parser rewrite:
     use liblutil's ldif_read_record instead of read_one_record
     track line numbers across entire LDIF instead of just for a single
	entry, to allow easier locating of errors. (we can also add the
	-j jump option later.)
     split Add/Modify parse paths, precompute size of pmods instead of
   	continuously using realloc.
   Entry processing is now linear time instead of n^2 with entry size."

Looks like a test case which uses controls is also needed.