[Date Prev][Date Next] [Chronological] [Thread] [Top]

ITS#4603 non-blocking socket breaks ber_flush

Waiting on select inside ber_flush here would completely defeat the 
purpose of using a non-blocking socket - i.e., the ber_flush call would 
block. Any form of retrying should be done by the caller of ber_flush, 
since they presumably know why they set the socket as non-blocking in 
the first place, and they know best what kind of retry strategy to use.

I think this patch should be rejected. This ITS will be closed.

   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc
   OpenLDAP Core Team            http://www.openldap.org/project/