[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: variable used before set in servers/slapd/syncrepl.c (ITS#4331)

On Wed, Jan 11, 2006 at 08:33:31PM +0000, Pierangelo Masarati wrote:
> > I was going through our bugzilla closing old OpenLDAP bugs when I found
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=160138
> > To my suprise, that code is still in 2.3.17, and is clearly broken.  "newp"
> is
> > not set in any way before the dn_match call.  I would guess that the match is
> > supposed to be against "nnewp", but I don't understand the code enough to be
> > sure.
> Correct, good catch.  Yes, the test was clearly supposed to be for nnewp, which
> contains the normalized parent's DN, so the comparison reduces to a memcmp();
> then the pretty form in newp is used to propagate the operation.
> Fixed in HEAD; thanks, p.

I'm looking through all the warning messages generated when I build
2.3.17.  Expect another bug report when I've gone through them all.
Most of them are "warning: too many arguments for format" because of
the Debug macro (I think), but a few of them look like they might be

			-- JF