[Date Prev][Date Next] [Chronological] [Thread] [Top]

(ITS#4105) code editing error?



Full_Name: Simon Raven
Version: 2.3.7 -> CVS HEAD
OS: linux 2.6
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (66.11.160.83)


hi,

was diffing a clean 2.3.7 tree and CVS HEAD from earlier today (oct 23 19:34:54
UTC 2005) and encountered what seems to be an editing bug, upon further
viewing.

occurs in libraries/libldap/init.c, line around line 110. here's the diff:

=== cut ===
--- openldap2.3_2.3.7.orig/libraries/libldap/init.c	2005-08-31
13:11:42.000000000 -0400
+++ openldap-CVS/libraries/libldap/init.c	2005-10-15 07:42:30.851748867 -0400
@@ -110,7 +110,7 @@
 	{0, ATTR_NONE,		NULL,		NULL,	0}
 };
 
-#define MAX_LDAP_ATTR_LEN  sizeof("TLS_CACERTDIR")
+#define MAX_LDAP_ATTR_LEN  sizeof("TLS_CIPHER_SUITE")
 #define MAX_LDAP_ENV_PREFIX_LEN 8
 
 static void openldap_ldap_init_w_conf(
=== cut ===

seems to me that TLS_CACERTDIR should stay in, and the add for TLS_CIPHER_SUITE
be added, instead of the CACERTDIR getting removed, and the other getting added.
unless i'm missing the point and it should get removed. if so, just close this
ITS submission without further ado.

thanks