[Date Prev][Date Next]
Re: (ITS#3854) variables used uninitialized: acl.c, accesslog.c
overlays/accesslog.c has been fixed; I believe acl.c has been totally
reworked so this ITS is probably no longer relevant.
> Full_Name: Hallvard B Furuseth
> Version: HEAD
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (188.8.131.52)
> Submitted by: hallvard
> * slapd/acl.c:
> slap_access_allowed(): 'mask' is used uninitialized after 'goto done' in
> #ifdef LDAP_SLAPI and 'if ( access_level >= ACL_WRITE ...)', and after
> 'if ( st_same_attr )' when 'if ( !ACL_IS_INVALID... )' is not taken.
> access_allowed_mask() in #ifdef SLAP_OVERLAY_ACCESS:
> 'control' is used but never initialized.
> acl_mask_dn(): 'level' is initialized too late under b->a_style ==
> * overlays/accesslog.c:
> accesslog_response(): 'a' is used uninitialized in the loop in case
> LOG_EN_MODIFY. Also, it looks a bit fragile (against changes in slapd,
> if nothing else) to not have a 'default:' in the 'switch ( op->o_tag )'
> and 'switch( m->sml_op )'.
-- Howard Chu
Chief Architect, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc
OpenLDAP Core Team http://www.openldap.org/project/