(ITS#3854) variables used uninitialized: acl.c, accesslog.c

[h.b.furuseth@usit.uio.no]

Full_Name: Hallvard B Furuseth
Version: HEAD
OS: Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (129.240.186.42)
Submitted by: hallvard


* slapd/acl.c:

slap_access_allowed(): 'mask' is used uninitialized after 'goto done' in
#ifdef LDAP_SLAPI and 'if ( access_level >= ACL_WRITE ...)', and after
'if ( st_same_attr )' when 'if ( !ACL_IS_INVALID... )' is not taken.

access_allowed_mask() in #ifdef SLAP_OVERLAY_ACCESS:
'control' is used but never initialized.

acl_mask_dn(): 'level' is initialized too late under b->a_style ==
ACL_STYLE_LEVEL.


* overlays/accesslog.c:

accesslog_response(): 'a' is used uninitialized in the loop in case
LOG_EN_MODIFY.  Also, it looks a bit fragile (against changes in slapd,
if nothing else) to not have a 'default:' in the 'switch ( op->o_tag )'
and 'switch( m->sml_op )'.