[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#3755) OpenLDAP breaks strict aliasing rules

On Friday 03 June 2005 08:43, Howard Chu wrote:
> rhafer@suse.de wrote:
> >On Wednesday 01 June 2005 14:40, rhafer@suse.de wrote:
> >>The uploaded patch currently contains just fixes for libldap and
> >> the client tools. There are also some issues in the slapd code.
> >> I'll upload a seperate patch for that later.
> >
> >Find it here:
> >
> >ftp://ftp.openldap.org/incoming/rhafer-2005-06-01_slapd_strict-alias
> >ing.dif
> I'm skeptical that any of these patches are necessary. In particular,
> a BerElementBuffer is just a character array, and it is always legal
> for characters to alias any other type.
I guess you are right about the BerElementBuffer. Maybe I was a bit 
over-restrictive in trying to silence every aliasing warning that gcc 
threw at me :).
But I a still not sure e.g. about the changes in acl.c. (SetCookie 
aliasing a AciSetCookie). And in sl_malloc.c (void and slap_heap).
Some patches in libldap might be valid as well.