[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#3569) Issue with multiple suffixes in a single bdb backend

john_de_f@hotmail.com wrote:

>Thank you for the reply. I searched the known bug list; is this a duplicate?
>Also, I have implemented a patch in back-bdb/cache.c to select the correct 
>suffix, but now that I read your comment about backend.c, I see it's not the 
>most appropriate fix. Would a patch to backend.c along the lines you 
>suggested be considered for 2.2.x, or are all modifications of this type 
>confined to 2.3? If so, I'll just go along with my local fix.
Patching select_backend() will affect 30-some files, so I'm not sure 
we'd want to change this in 2.2. On the other hand, a patch against CVS 
HEAD would probably port equally well to 2.3 and 2.2. Multiple-suffix 
support is not a priority for us though, it's preferred that you use one 
suffix per database. Overall I'm less inclined to patch this in 2.2.

As a hint, you need to add an (int *) argument to select_backend, and 
add an o_isuffix (or something) to the Operation structure in slap.h, 
and reference it consistently in back-bdb.

>>From: Howard Chu <hyc@symas.com>
>>To: john_de_f@hotmail.com
>>CC: openldap-its@OpenLDAP.org
>>Subject: Re: (ITS#3569) Issue with multiple suffixes in a single bdb 
>>Date: Thu, 24 Feb 2005 22:17:52 -0800
>>This is a known deficiency in back-bdb, your analysis is correct. The ideal 
>>fix would be for slapd/backend.c:select_backend() to return the index of 
>>the suffix it matched in addition to the backend it found, so that this 
>>comparison need not be performed redundantly throughout the rest of the 
>>code. I may do this in 2.3, but no plans for 2.2.

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and Support