Re: (ITS#3458) ppolicy overlay doesn't build (missing declarations)

[ando@sys-net.it]

hyc@symas.com wrote:

>ando@sys-net.it wrote:
>
>  
>
>>Full_Name: Pierangelo Masarati
>>Version: 2.3
>>OS: Linux
>>URL: ftp://ftp.openldap.org/incoming/
>>Submission from: (NULL) (131.175.154.56)
>>
>>
>>ppolicy overlay doesn't build because of missing declarations, which are hidden
>>in include/ldap.h behind #ifdef LDAP_DEVEL; don't know what's best to fix it:
>>#define LDAP_DEVEL (or better #define LDAP_CONTROL_PASSWORDPOLICYREQUEST, as
>>conditionally defined in include/ldap.h when LDAP_DEVEL is #define'd) or inhibit
>>the building of the overlay #ifndef'd LDAP_DEVEL or so.
>> 
>>
>>    
>>
>I'm still undecided here. I would like to see this code get released, 
>but I guess this is still too soon. The code is now stale and needs to 
>be brought up to date with the current draft anyway. So perhaps we 
>should remove the ppolicy overlay from the 2.3 build for now.
>
I would consider the ppolicy a nice plus for 2.3, but it's up to you. 
 In any case, I see that there's ppolicy code in libldap, in the client 
tools and in the overlay, so there's plenty of places for potential 
build problems.  What about keeping it as is but wrapped around a sort 
of LDAP_PRERELEASE macro?  Something that by default is not enabled, and 
one may use at own risk, but in a release, not in HEAD.

p.




    SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497