[Date Prev][Date Next]
Re: global configuration patch (ITS#3354)
I note that there is no explanation as to why this
change is being suggested. However, given Howard's recent
comments on -devel, I presume these relate to the cn=config
work. I will assume this in my comments below.
The appear appears to move more than global configuration
variables to a new global structure. For instance, a number
of mutexes and other state variables (like schema_init_done)
are moved into this global structure. Also, some monitoring
information was moved. This, I think, is unwarranted in
general and certainly not needed for cn=config work (which
I understand this patch relates to).
I think the patch should be reworked so that it only
moves global CONFIGURATION variables to a new global
configuration structure. Also, the patch should
deal with the full ripple effect of the changes it
makes (it seems not to update everything dependent
on the changes made).
However, that said, I see that Howard has already committed
your patch (with changes). I will consult with him shortly
to determine whether it best to back out the changes or to
resolve the above issues from where things no lie.
At 12:44 AM 10/1/2004, firstname.lastname@example.org wrote:
>Full_Name: james ozone
>Submission from: (NULL) (188.8.131.52)
>this patch migrates all global configuration variables (*except
>ldap_syslog/ldap_syslog_level) into a single struct, which is currently
>referenced by frontendDB->be_private.
>ldap_syslog is used elsewhere; the impact of migrating it isn't clear.
>The attached modifications to OpenLDAP Software are subject to the following
>Copyright 2004 Symas Corporation
>Redistribution and use in source and binary forms, with or without
>are permitted only as authorized by the OpenLDAP Public License.
>this ITS replaces #3353, in which i did not appear to enter my full name.