[Date Prev][Date Next]
Re: constraint overlay (ITS#3292)
Thanks for the feedback Kurt. Neil is the best person to respond on
these points. He is on vacation right now, I believe till the end of
August. He will respond when he gets back.
Kurt D. Zeilenga wrote:
> The first issue that concerned me is the charset constraint
> and use of iconv. The code appears to be incorrect because,
> if I understand the iconv API, it doing a conversion between
> X and X (where X is the specified charset to constrain to)
> instead of between UTF-8 encoded Unicode and X. Note that
> in slapd(8), attribute (and assertion) values of Directory
> String syntax (and other character string syntaxes) are
> stored as UTF-8 encoded Unicode.
> The second issue is that iconv(3) routines are not widely
> available (in default installs of supported operating system
> platforms). Hence, I suggest the code only include charset
> constraint support of iconv(3) is available. This implies
> a requirement to auto-detect iconv(3) existance to enable
> the feature.
> The third issue is that the module linking doesn't include
> -liconv (which existance should also be auto-detected).
> The fourth issue is documentation. A manpage should be provided.
> Another issue I have is whether this should be in slapd/overlays
> or in contrib/slapd-modules. But that's more of issue for
> the committers to resolve that you.
> Regards, Kurt
> At 10:12 PM 8/18/2004, email@example.com wrote:
>>Full_Name: Kartik Subbarao
>>Submission from: (NULL) (126.96.36.199)
>>I have uploaded Neil Dunbar's constraint overlay, and patches to auxiliary build
>>files such as the Makefile.in in the overlays directory, the top level
>>configure.in, and portable.h.in. The constraint overlay limits the values which
>>can be placed into an attribute, over and above the limits placed by the schema.
>>It traps only LDAP adds and modify commands (and only seeks to control the add
>>and modify value mods of a modify). The constraint can be specified as a
>>character set (e.g. US-ASCII) or as a regular expression.