[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Global overlay (ITS#3080)

> It looks good to me but I don't understand what all the "FIXME:
> temporary" parts are about.

as far as I remember, I put them there because at that point
the o_request structure is not set in the original code yet,
and the data I'm setting there is not in the same state as it
is when regular overlays are invoked.  For instance, in case
of modify.c, at the point the frontend call is invoked the
input has not passed slap_mods_check() and slap_mods_opattrs(),
and similar issues arise for other operations.

In fact, in some cases it appears that input preparation and
checking is streamlined in the direction of anticipating costly
checks, so that an invalid input can be rejected as soon as
possible and with the least effort.  This is wise, but may
inhibit abstraction.

As a consequence, I cannot guarantee that overlays that currently
work between frontend and backend will work as well within the
frontend.  This would be the best solution; however, even if this
is not true, at least we have a mechanism to put layers in the
frontend as well.

> In particular, there are features already in this patch that I had
> planned for back-config, so I would like to see this work committed.

I can quickly commit it, although I'm very busy these days, so
I might not be able to follow its integration with current code,
and track issues.


Pierangelo Masarati

    SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497