Re: OpenLDAP MinGW GDBM 1.8.0 Patch (ITS#2953)

[Kurt@OpenLDAP.org]

As this is a patch against GDBM, it should be submitted to
maintainers of GDBM.  A copy is welcomed in our FAQ as
well, please feel free to submit that addition yourself.
(The FAQ is interactive.)

Kurt


At 02:56 PM 2/5/2004, jason@raneses.com wrote:
>Full_Name: Jason Raneses
>Version: 2.2.5
>OS: Windows
>URL: ftp://ftp.openldap.org/incoming/
>Submission from: (NULL) (206.54.156.254)
>
>
>In the OpenLDAP FAQ regarding building OpenLDAP using MinGW, there is an error
>in the referenced GDBM 1.8.0 patch.
>
>_LK_UNLOCK is being referenced in the patch, which is invalid.  _LK_UNLCK is the
>correct definition.
>
>The original patch is located:
>http://www.openldap.org/faq/data/cache/380.html
>
>The following hunk needs to be changed from:
>
>85a90,105
>> #elif defined(_WIN32)
>> 
>> #define UNLOCK_FILE(dbf)                              \
>>       {                                               \
>>           _lseek(dbf->desc, 0, SEEK_SET);             \
>>           _locking(dbf->desc, _LK_UNLOCK, 1);         \
>>       }
>> 
>> #define READLOCK_FILE(dbf)                                    \
>>       {                                                       \
>>           _lseek(dbf->desc, 0, SEEK_SET);                     \
>>           lock_val = _locking(dbf->desc, _LK_NBLCK, 1);       \
>>       }
>> 
>> #define WRITELOCK_FILE(dbf)   READLOCK_FILE(dbf)
>
>to:
>
>85a90,105
>> #elif defined(_WIN32)
>> 
>> #define UNLOCK_FILE(dbf)                              \
>>       {                                               \
>>           _lseek(dbf->desc, 0, SEEK_SET);             \
>>           _locking(dbf->desc, _LK_UNLCK, 1);          \
>>       }
>> 
>> #define READLOCK_FILE(dbf)                                    \
>>       {                                                       \
>>           _lseek(dbf->desc, 0, SEEK_SET);                     \
>>           lock_val = _locking(dbf->desc, _LK_NBLCK, 1);       \
>>       }
>> 
>> #define WRITELOCK_FILE(dbf)   READLOCK_FILE(dbf)
>
>Please let me know if you have any questions...
>
>Jason