[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Possible typo in slapd's slap_auxprop_init() function (ITS#2909)

Thanks, fixed in HEAD.

At 03:29 PM 1/7/2004, nalin@redhat.com wrote:
>Full_Name: Nalin Dahyabhai
>Version: REL_ENG_2_1
>OS: Fedora Core development tree
>URL: ftp://ftp.openldap.org/incoming/
>Submission from: (NULL) (
>In servers/slapd/sasl.c, the check at the beginning of slap_auxprop_init() (that
>out_version and plug are not NULL) uses the bitwise "or" when the logical "or"
>is what's likely intended.
>This doesn't appear to have any impact (both out_version and plug are logically
>inverted before this, so the values being used are either 0 or 1), but it might
>be better if it were changed anyway.