Error in 2.1.22 libraries/liblber/Makefile.in (ITS#2797)

[jsdy@center.osis.gov]

Full_Name: Joseph S D Yao
Version: 2.1.22
OS: Linux - Red Hat 8.0 w/patches and Bastille
URL: ftp://ftp.openldap.org/incoming/Joseph-Yao-031027.txt
Submission from: (NULL) (204.178.104.233)


In libraries/liblber/Makefile.in, the install-local target has the following
code:

-$(MKDIR) $(DESTDIR)$(libdir)
        $(LTINSTALL) $(INSTALLFLAGS) -m 644 $(LIBRARY) $(DESTDIR)$(libdir)
        $(LTFINISH) $(DESTDIR)$libdir

If you look closely, you'll see that the last line evaluates $l to the null
string and proceeds to operate on directory "ibdir".  This did not cause my next
reported bug, but was at the same place.

It should read as follows.

-$(MKDIR) $(DESTDIR)$(libdir)
        $(LTINSTALL) $(INSTALLFLAGS) -m 644 $(LIBRARY) $(DESTDIR)$(libdir)
        $(LTFINISH) $(DESTDIR)$(libdir)

Note the added parentheses in the last line.

Thanks.

Joe Yao

[OK, now that you bring up guidelines for contributing - does a 2-character
change require a patch file on a public URL???]