[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: back overlay (ITS#2751)

> -----Original Message-----
> From: owner-openldap-bugs@OpenLDAP.org
> [mailto:owner-openldap-bugs@OpenLDAP.org]On Behalf Of ando@sys-net.it

> Full_Name: Pierangelo Masarati
> Version: HEAD
> OS: Linux
> URL:
> http://www.sys-net.it/~ando/Download/backover.c.ando-2003-10-05.patch
> Submission from: (NULL) (
> Submitted by: ando
> This ITS is only to keep track of the changes I'm trying to
> set up before
> I commit anything.  While playing with overlays I noted that:
> 1) there is something I don't understand when dealing with
> "send entry"
>    callbacks, which is fixed by the attached patch; or am I
> missing something?

The first part of this patch is not needed. The send_* functions will do
their default behavior when no callbacks are called.

The second part of the patch may be correct in resetting the op structure,
but the check to set UNWILLING_TO_PERFORM must remain - this case occurs when
neither the overlays nor the backend itself implemented the selected
operation. Specifically, it is not legal for this function to return
SLAP_CB_CONTINUE to the slapd frontend; it can only return legitimate LDAP
result codes indicating the final disposition of an operation.

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and Support