[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Patch to provide peer name to shell backends (ITS#2448)

My main concern with this patch is the use of environmental
variables to passing values from the back-shell to the
underlying shell scripts is not thread safe.  Presently it
possible to make back-shell work with threads.  With
this change, additional serialization would be required.

The alternative you suggest is, I think, a bit problematic
due to command line restrictions on some platforms.

A more general approach would be extend the intermediate
format to carry additional information.  However,
interoperability would be a concern here.

I have placed this ITS in a 'suspended' state as further
discussions are necessary to determine whether this
patch, or others in this area, should be accepted.

At 08:59 AM 4/15/2003, xml@mailandnews.com wrote:
>Full_Name: Paul Ashton
>Version: 2.1.17
>OS: Linux 2.4.20
>URL: http://www.sbrk.co.uk:9080/openldap-peername.patch
>Submission from: (NULL) (
>We at http://www.gnomemeeting.org/ have been running an ILS server
>for some time which is a perl server run via a shell backend from
>openldap (due to the fact that it isn't quite LDAP compliant).
>One requirement is that whoever registers an entry
>can be the only one that modifies or deletes it, and we base that
>on the IP address. Unfortunately, openldap doesn't propogate
>the peer address to shell backends so I created a patch to do so.
>This currently uses an environment variable but could easily
>also use a command line argument if thought preferable. I attach
>the current patch (tested against 2.1.12 and 2.1.17).
>Please consider for inclusion or inform me how I could make it
>Not sure if it needs a license statement since it's so trivial, but
>just in case:
>Written by Paul Ashton and placed into the public domain.