[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: Index corruption and crash in back-ldbm (ITS#2348)

> -----Original Message-----
> From: vek@pharmapartners.nl [mailto:vek@pharmapartners.nl]

> On Wed, 12 Mar 2003 hyc@highlandsun.com wrote:

> > Hm... I think we can change this a bit, instead of testing OR EQUAL:
> > 	if (id == ID_BLOCK_ID(idl, i))
> > then the ID is already present and doesn't need inserting
> at all. So the
> > other tests can be left as-is, we can just return early if
> the id is equal.
> >
> I'm afraid that is not always a valid assumption.

sigh... You're right, if an ID is deleted from an IDL the block boundaries
are not updated. So simply changing an attribute and causing it to index into
a different slot will cause problems. I'll fix this as you suggested.

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and Support