RE: CLDAP is not working in 2.1.13 (ITS#2335)

[Kurt@OpenLDAP.org]

At 06:15 AM 3/2/2003, hyc@highlandsun.com wrote:
>Your fix is not correct and will fail for messages of particular sizes. I've
>committed a fix to CVS HEAD that should work in all cases, please test.

I've tested the fix on Linux/ppc64.  Works fine.

>Also
>in the future, please submit a new ITS when raising a separate issue.
>
>  -- Howard Chu
>  Chief Architect, Symas Corp.       Director, Highland Sun
>  http://www.symas.com               http://highlandsun.com/hyc
>  Symas: Premier OpenSource Development and Support
>
>> -----Original Message-----
>> From: owner-openldap-bugs@OpenLDAP.org
>> [mailto:owner-openldap-bugs@OpenLDAP.org]On Behalf Of
>> maxchern@corp.earthlink.net
>> Sent: Saturday, March 01, 2003 12:16 AM
>> To: openldap-its@OpenLDAP.org
>> Subject: Re: CLDAP is not working in 2.1.13 (ITS#2335)
>>
>>
>>
>> Thank you, Howard. It does work. However, it only works for
>> 32 bits mode.
>> For 64 bits, somehow the code will hang while expecting to
>> receive another
>> packet due to the calculation of the data size.
>>
>> Here is what I did to make it work for both modes (32 bits
>> and 64 bits),
>> please verify.
>>
>> in libraries/liblber/io.c,v 1.80 2003/01/31 21:45:19
>>
>> 507,508c507,508
>> <               sblen=ber_int_sb_read( sb, ber->ber_rwptr,
>> <                       (char *)(&ber->ber_usertag+1)-ber->ber_rwptr);
>> ---
>> >               sblen = ber_int_sb_read( sb, ber->ber_rwptr,
>> >                       ((char*) &ber->ber_usertag +
>> 1)-ber->ber_rwptr);
>>
>>
>> On Fri, 28 Feb 2003, Howard Chu wrote:
>>
>> > Yes, it was quite broken, on both the server and the
>> client. A fix is in CVS
>> > HEAD, please test.
>> >   libldap/result.c -r1.82 -> -r1.83
>> >   servers/slapd/connection.c -r1.206 -> -r1.208
>> >                 result.c     -r1.172 -> -r1.174
>> >                 slap.h       -r1.410 -> -r1.411
>> >
>> >
>>
>> Max Chern, Staff Software Engineer   |  Voice: 626-296-5014
>> EarthLink, Inc.                      |  Fax:   626-296-4168
>> maxchern@corp.earthlink.net          |  3100 New York Drive, Ste. 201
>> http://www.earthlink.net/            |  Pasadena, CA 91107
>>