Re: Odd 'if ( be_isroot )' in servers/slapd/back-ldbm/modrdn.c (ITS#1761)

[masarati@aero.polimi.it]

mark.horstman@sbc.com wrote:
> 
> Full_Name: Mark A. Horstman
> Version: 2.0.23
> OS: Solaris 2.8
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (209.184.192.23)
> 
> In servers/slapd/back-ldbm/modrdn.c:
> 
>    176          /* no parent, must be root to modify rdn */
>    177          isroot = be_isroot( be, op->o_ndn );
> -->178          if ( ! be_isroot ) {
> 
> and
> 
>    294              /* no parent, must be root to modify newSuperior */
>    295              if ( isroot == -1 ) {
>    296                  isroot = be_isroot( be, op->o_ndn );
>    297              }
>    298
> -->299              if ( ! be_isroot ) {
> 
> Shouldn't those be 'if ( ! isroot )'?  The 'if ( ! be_isroot )' condition will
> always be true.

Correct. The code in HEAD is fine; I guess 
it was improperly sucked in REL_ENG :)

Kurt, is it fine if I fix it?

Ando.

-- 
Dr. Pierangelo Masarati               | voice: +39 02 2399 8309
Dip. Ing. Aerospaziale                | fax:   +39 02 2399 8334
Politecnico di Milano                 |
mailto:pierangelo.masarati@polimi.it
via La Masa 34, 20156 Milano, Italy   |
http://www.aero.polimi.it/~masarati