[Date Prev][Date Next] [Chronological] [Thread] [Top]

Patch: aclparse.c bugs (ITS#1752)

Full_Name: Hallvard B. Furuseth
Version: HEAD (2002-04-12)
OS: Linux
URL: http://folk.uio.no/hbf/OpenLDAP/aclparse.txt
Submission from: (NULL) (

Bug fixes:
- acl_regex_normalized_dn(pattern):
  * used pattern->bv_len even though it claimed not to,
  * would walk past the end of strings that ended (incorrectly)
    with a single '\'.
- style=regex checked for "^.*$$" twice but not for "^.*$".
- the code did not notice if dnNormalize2() failed, and would
  (at least in one case) treat a bad DN as '*'.
Some cleanup:
- changed regtest() to return void, since the return value was unused.
- changed acl_regex_normalized_dn() to take a string input argument
  instead of a half-filled berval, it looks saner that way.