[Date Prev][Date Next] [Chronological] [Thread] [Top]

Patch: Integer type inconsistencies (ITS#1732)

Full_Name: Hallvard B. Furuseth
Version: HEAD (2002-04-07)
OS: Linux
URL: http://folk.uio.no/hbf/OpenLDAP/sign.txt
Submission from: (NULL) (

Here are some fixes for mismatched integer types; cases where
the sign is wrong.  Typically a ber_tag_t which receives an
int value and is later compared with an int, maybe -1.

There are 3 sections:

First removal of one strange cast of an unsigned value to (int),
where the result is compared with an unsigned value.  Either 
there is some strange purpose to this, or the cast is a holdover
from a time when the integer types in the function were different.

Section 2 has various plain fixes.

Section 3 has patches with no effect except to remove most remaining
'comparison between signed and unsigned' warnings, which is how I caught
the above bugs.  Either it casts some constant to int, or it declares an
index variable as unsigned (typically because it meets a size_t).