[Date Prev][Date Next] [Chronological] [Thread] [Top]

Untested patch: back-tcl used wrong types (ITS#1719)

Full_Name: Hallvard B. Furuseth
Version: HEAD (2002-04-02)
URL: http://folk.uio.no/hbf/OpenLDAP/tcl.txt
Submission from: (NULL) (

This patch is untested (except for compiling it); a compiler bug
prevented me from compiling it completely.

back-tcl is outdated:
- It expected be->be_suffix to be a char**, not a struct berval**.
- It expected the string arguments to the tcl_back_*() routines
  to be const char*, not struct berval.
- tcl_back_compare() expected an Ava* instead of AttributeAssertion*.
- tcl_back_modify() expected an LDAPModList* instead of Modifications*.
- tcl_back_modrdn() expected too few arguments.
- And finally, back-tcl did printf(%ld, ber_int_t) instead of
  printf(%ld, (long) ber_int_t).

Note: This patch merely ignores the two new arguments nnewrdn and
nnewSuperior to tcl_back_modrdn(), because that's what back-perl does.
I have no idea what these arguments do.  Whoever invented them should
have a look at tcl_modrdn.c.  (And maybe back-perl/modrdn.c too.)