[Date Prev][Date Next] [Chronological] [Thread] [Top]

Assertion in dnNormalize after SASL authentication (ITS#1696)



Full_Name: Simon Wilkinson
Version: 2.1.0alpha
OS: Linux
URL: 
Submission from: (NULL) (62.6.93.21)


slap_parseURI calls dnNormalize2 with the length of the berval set to 1, rather
than
the correct length of the string. This causes dnNormalize to assert. The code
that does this is marked with a FIXME - I guess the time has come to fix it.

I believe that a minimal fix is to change

is_dn:          bv.bv_len = 1;

to

is_dn:		bv.bv_len = strlen(bv.bv_val);

It would also be possible to tidy the code to remove the 'goto', and neaten
the codepath, but at the expense of an additional call to strncasecmp in some
situations. Let me know if you're interested in a patch for that.