Re: assert failure in acl.c when doing moddn (ITS#1582)

[masarati@aero.polimi.it]

leifj@it.su.se wrote:
> 
> Full_Name: Leif Johansson
> Version: 2.0.21
> OS: linux
> URL:
> Submission from: (NULL) (130.237.91.18)
> 
> I am doing a moddn and getting an assert failure in servers/slapd/acl.c:948. It
> seems
> like acl_check_modlist does not implement access control for moddn operation.
> The
> assert causes database corruption.
> 
> I enclose the tail end of the debugging output of slapd -d 65535:

Tracked, thanks.  The fix is very easy:

<diff>
Index: servers/slapd/acl.c
===================================================================
RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/acl.c,v
retrieving revision 1.27.2.20
diff -u -r1.27.2.20 acl.c
--- servers/slapd/acl.c 2002/01/15 15:28:13     1.27.2.20
+++ servers/slapd/acl.c 2002/02/06 06:29:13
@@ -915,6 +915,7 @@
                        /* fall thru to check value to add */
 
                case LDAP_MOD_ADD:
+               case SLAP_MOD_SOFTADD:
                        assert( mlist->sml_bvalues != NULL );
 
                        for ( i = 0; mlist->sml_bvalues[i] != NULL; i++
) {
</diff>

I'll commit it to HEAD in a moment.

Pierangelo

-- 
Dr. Pierangelo Masarati               | voice: +39 02 2399 8309
Dip. Ing. Aerospaziale                | fax:   +39 02 2399 8334
Politecnico di Milano                 |
mailto:pierangelo.masarati@polimi.it
via La Masa 34, 20156 Milano, Italy   |
http://www.aero.polimi.it/~masarati