Re: Probable bug in use of strcasecmp in servers/slapd/acl.c (ITS#1516)

[Kurt@OpenLDAP.org]

This should now be fixed in both HEAD and OPENLDAP_REL_ENG_2.
Please test.

Thanks, Kurt

At 08:13 AM 2002-01-08, mark.blackman@netscalibur.co.uk wrote:
>Full_Name: Mark Blackman
>Version: 2.0.19
>OS: FreeBSD 4.4
>URL: http://www.users.dircon.co.uk/~canyon/patches/strcasecmp.patch-2.0.19
>Submission from: (NULL) (195.157.3.43)
>
>
>I believe that 4  uses of strcasecmp in servers/slapd/acl.c are in 
>error and use the reverse logic to that intended. 
>
>Namely, strcasecmp returns a 0 on a string match (case insensitive)
>but the logic in parts of acl.c suggest that the original author
>assumed a return value of 1 on string match. This is during
>the acl <who> clause evaluation.
>
>I've included a patch that reverses this logic to that
>probably intended. I posted to openldap-devel to confirm
>that it was a bug.