[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Present filters on unrecognized attribute types (ITS#1439)




--On Wednesday, December 05, 2001 2:16 AM +0000 Kurt Zeilenga 
<openldap-its@OpenLDAP.org> wrote:

> fix applied to HEAD and OPENLDAP_REL_ENG_2, please test
>

The compare needs to turn out false, not undefined. Diff to HEAD included.
I didn't find my patch in the OPENLDAP_REL_ENG_2 nor in the 
OPENLDAP_REL_ENG_2_0_18 branch,
which both reference a somewhat old version of the file on a different 
branch. Is this intentional?

Index: filter.c
===================================================================
RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/filter.c,v
retrieving revision 1.62
diff -u -r1.62 filter.c
--- filter.c    2001/12/05 02:21:39     1.62
+++ filter.c    2001/12/05 09:42:18
@@ -210,7 +210,7 @@
                if( err != LDAP_SUCCESS ) {
                        /* unrecognized attribute description or other 
error */
                        f->f_choice = SLAPD_FILTER_COMPUTED;
-                       f->f_result = SLAPD_COMPARE_UNDEFINED;
+                       f->f_result = SLAPD_COMPARE_FALSE;
                        *fstr = ch_strdup( "(unrecogized=*)" );
                        ch_free( type.bv_val );
                        err = LDAP_SUCCESS;