[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: librewrite's rc_continue label



Sorry for the empty reply :)

Mei-Hui Su wrote:

> Hi,
>
>  I just grabbed a copy of cvs developement tree and tried it
> on solaris 2.7. This is not really an openldap bug but sun's
> compiler bug but I thought should put it in just so someone
> else won't get stuck.
>
>   in librewrite/context.c line #401
>
> rc_continue:    /* sent here by actions that require to continue */
>
>   }
>
>  It seems that Sun's compiler can't parse that correctly,
>
> Here is a small example,
> int main()
> {
>   int i;
>   for(i=0;i<10;i++) {
>     goto alabel;
> alabel:
>   }
>   return 0;
> }
>
> and compiler complains
> "t.c", line 8: syntax error before or at: }
> "t.c", line 10: warning: end-of-loop code not reached
> "t.c", line 14: syntax error before or at: <EOF>

I cannot try to compile it on a sun; please, try adding a semcolon after
the colon

alabel:;

This should fix it; in case, I'll fix the bug.


>
>
>   There is a typo in librewrite/rewrite-int.h,
>
> //#define REWRITE_SUBMATCH_ESCAPE                      '\\'
> ^^
>
>   There are 2 typos in librewrite/rule.c (line#272, 283)
>
>                 // charray_free( res );
>                 ^^
>
>   There is a typo in librewrite/rewrite.c line#77

Sure. gcc supports C++ style comments, which were not supposed to be
committed. I'll fix it ASAP.
Thanks.

BTW, please use the ITS for this kind of problems; otherwise the
openldap-devel list for comments and questions about DEVEL
topics, if you are not sure it is a bug. Thanks.

Pierangelo.

--
Dr. Pierangelo Masarati               | voice: +39 02 2399 8309
Dip. Ing. Aerospaziale                | fax:   +39 02 2399 8334
Politecnico di Milano                 | mailto:masarati@aero.polimi.it
via La Masa 34, 20156 Milano, Italy   | http://www.aero.polimi.it/~masarati