[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: Logging broken in -devel (ITS#1143)



I have made this fix and committed it.  Thanks.

> -----Original Message-----
> From: sxw@sxw.org.uk [mailto:sxw@sxw.org.uk]
> Sent: Thursday, May 10, 2001 2:27 PM
> To: openldap-its@OpenLDAP.org
> Subject: Logging broken in -devel (ITS#1143)
> 
> 
> Full_Name: Simon Wilkinson
> Version: 10/05/2001 CVS pull
> OS: Linux
> URL: http://www.dcs.ed.ac.uk/home/sxw/openldap-debug1.patch
> Submission from: (NULL) (129.215.199.88)
> 
> 
> Logging doesn't work correctly in the CVS HEAD branch. 
> 
> The problem is that with the NEW_LOGGING code, where global 
> values are used the
> code erroneously skips them (there's a 'return' where there 
> should be a
> 'break').
> For example -
> ./slapd -d 1
> 
> doesn't work, whereas ./slapd -d operation=1 does
> 
> A patch against libraries/lutil/debug.c is at the URL 
> referenced below. This
> patch
> replaces the erroneous return, and adds some additional 
> checking to allow the
> fall
> through to work correctly.
> 
> There are assorted other problems with the new debugging 
> code, I'll open
> individual
> reports for each of these.
>