[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Patch for making OpenLDAP 1.2.6 install correctly into $DESTDIR (ITS#278)

On Tue, Sep 07, 1999 at 11:20:08AM -0700, Kurt D. Zeilenga wrote:
> At 04:27 PM 9/7/99 GMT, bcollins@debian.org wrote:
> >On Tue, Sep 07, 1999 at 04:03:08PM +0000, j_sanchez@stl.es wrote:
> >> You are supposed to use TMPROOT:
> >> 
> >> 	make install TMPROOT=$RPM_BUILD_ROOT
> >> 
> >
> >TMPROOT is nice, but he is correct, that the best implementation is to
> >use $(DESTDIR) in the actual "install libfoo.so.1 $(DESTDIR)$(libdir)/"
> >lines. It's more compatible, and much more used as a standard.
> The TMPROOT solution is not advertised as being compatible and
> doesn't need to be.  As far as "best" implementation, that's
> debatable.  Both approaches can be problematic to maintain.
> I really don't care which approach is used (and maintained).  I do
> prefer that only one of the two mechanisms be supported.  I recommend
> the repackagers and other users of this feature suggest which
> approach they prefer to use and maintain.  If it's determined
> to switch to a $(DESTDIR) approach, I recommend that this be
> implemented in OpenLDAP-devel for release with 2.0 and leaving
> 1.2 "as is" in this regard.

As the Debian maintainer for the OpenLDAP package, I'de say I prefer the
$(DESTDIR) approach. This would have avoided all of the problems we had
with generated files obtaining the $TMPROOT prefix when installing, and we
can go back to generating man pages only at install time rather than
during the build phase.