Re: suspected bug in openldap-981116 acl

["Kurt D. Zeilenga" <Kurt@openldap.org>]

Thanks, patch committed to -devel.

At 11:14 PM 11/23/98 +0100, you wrote:
>Hi,
>
>i read some code and found the following construction in
>servers/slapd/acl.c:
>
>
>string_expand(char *newbuf, int bufsiz, char *pat, char *match,
>regmatch_t *matches)
>{
>[decls snipped]
>        flag = 0;
>        for ( dp = newbuf, sp = pat; size < 512 && *sp ; sp++) {
>--->                                        ^^^
>                /* did we previously see a $ */
>                if (flag) {
>                        if (*sp == '$') {
>                                *dp++ = '$';
>                                size++;
>                        } else if (*sp >= '0' && *sp <= '9' ) {
>[rest snipped]
>
>
>Should't the marked 512 rather be a `bufsiz'? The bufsiz parameter is
>never
>used in the function.
>
>There are more comments about style and efficient data structures.
>
>Regards
>
>J.Pietschmann
>Attachment Converted: "c:\home\kurt\data files\eudora\attach\smime2.p7s"
>