Full_Name: Jan Vcelak Version: 2.4.29 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (209.132.186.34) Hello, I have uploaded two patches with manual page fixes: ftp://ftp.openldap.org/incoming/jvcelak-20120222-0001-man-add-missing-options-to-the-client-tools.patch - typo in '-o' in --help output - missing '-C' in ldapsearch and ldapcompare - manpages all tools: + add -o description (general options) + add -N description (reverse DNS SASL host name canonicalization) - manpages ldapsearch, ldapcompare: + add -C (perform referral chasing) ftp://ftp.openldap.org/incoming/jvcelak-20120222-0002-man-add-SASL_NOCANON-option-to-ldap.conf-5.patch - add SASL_NOCANON option to ldap.conf(5) The attached files are derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the uploaded patches were developed by Red Hat. Red Hat has not assigned rights and/or interest in this work to any party. I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under the following terms. Red Hat hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.
jvcelak@redhat.com wrote: > Full_Name: Jan Vcelak > Version: 2.4.29 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (209.132.186.34) > > > Hello, > > I have uploaded two patches with manual page fixes: > > ftp://ftp.openldap.org/incoming/jvcelak-20120222-0001-man-add-missing-options-to-the-client-tools.patch > > - typo in '-o' in --help output > - missing '-C' in ldapsearch and ldapcompare > - manpages all tools: > + add -o description (general options) > + add -N description (reverse DNS SASL host name canonicalization) > - manpages ldapsearch, ldapcompare: > + add -C (perform referral chasing) The -C option is deprecated and intentionally undocumented. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
> The -C option is deprecated and intentionally undocumented. OK, I've uploaded updated patches, which exclude '-C': ftp://ftp.openldap.org/incoming/jvcelak-20120223-0001-man-add-missing-options-to-the-client-tools.patch ftp://ftp.openldap.org/incoming/jvcelak-20120223-0002-man-add-SASL_NOCANON-option-to-ldap.conf-5.patch Jan
Jan Vcelak wrote: >> The -C option is deprecated and intentionally undocumented. > > OK, I've uploaded updated patches, which exclude '-C': > > ftp://ftp.openldap.org/incoming/jvcelak-20120223-0001-man-add-missing-options-to-the-client-tools.patch > ftp://ftp.openldap.org/incoming/jvcelak-20120223-0002-man-add-SASL_NOCANON-option-to-ldap.conf-5.patch > > Jan > Thanks. Some of this overlaps ITS#7152. Will take a look at both to see which I like better. ;) It seems unnecessary to document ldif-wrap in all of the commands, since only ldapsearch actually produces LDIF output. The option isn't relevant for any of the others. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
> It seems unnecessary to document ldif-wrap in all of the commands, > since only > ldapsearch actually produces LDIF output. The option isn't relevant > for any of > the others. I know. Feel free to modify the changes as you wish. I just wanted to make the man page consistent across all tools, because the description of "-o" displayed with "ldaptool --help" is always the same. Jan
On Thu, 23 Feb 2012 20:31:09 GMT, hyc@symas.com wrote: > It seems unnecessary to document ldif-wrap in all of the commands, > since only ldapsearch actually produces LDIF output. No, controls can also request LDIF output. E.g. ldapmodify -e preread -o ldif-wrap=20 wraps after column... 22?? New ITS coming up. -- Hallvard
h.b.furuseth@usit.uio.no wrote: > On Thu, 23 Feb 2012 20:31:09 GMT, hyc@symas.com wrote: >> It seems unnecessary to document ldif-wrap in all of the commands, >> since only ldapsearch actually produces LDIF output. > > No, controls can also request LDIF output. E.g. > ldapmodify -e preread -o ldif-wrap=20 > wraps after column... 22?? New ITS coming up. > OK, in that case I don't see any reason to tweak that part of the patch. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
changed notes changed state Open to Test moved from Incoming to Documentation
changed notes changed state Test to Release
changed notes changed state Release to Closed
changed notes
Hello, this was not fixed entirely. > ftp://ftp.openldap.org/incoming/jvcelak-20120223-0002-man-add-SASL_NOCANON-option-to-ldap.conf-5.patch SASL_NOCANON option is still missing in ldap.conf(5). Jan
added to master, with cleanups added to RE24
Hi Jan, I've applied the SASL_NOCANON patch that was missed previously. Thanks for the submission! --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>