Issue 8739 - Better check for fsync on FreeBSD
Summary: Better check for fsync on FreeBSD
Status: UNCONFIRMED
Alias: None
Product: LMDB
Classification: Unclassified
Component: liblmdb (show other issues)
Version: 0.9.21
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords: has_patch
Depends on:
Blocks:
 
Reported: 2017-09-22 12:38 UTC by gahr@gahr.ch
Modified: 2020-03-16 23:42 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description gahr@gahr.ch 2017-09-22 12:38:17 UTC 
Full_Name: Pietro Cerutti
Version: lmdb 0.9.21
OS: FreeBSD 11.1
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (69.191.176.33)


This patch allows for a finer-grained control over which FreeBSD versions
support fdatasync. This allows us to get rid of a custom patch in our ports.

--- mdb.c.orig  2017-06-01 16:51:10 UTC
+++ mdb.c
@@ -125,6 +125,8 @@ typedef SSIZE_T     ssize_t;
 # define MDB_FDATASYNC         fsync
 #elif defined(ANDROID)
 # define MDB_FDATASYNC         fsync
+#elif defined(__FreeBSD_version) && __FreeBSD_version < 1101000
+# define MDB_FDATASYNC         fsync
 #endif

 #ifndef _WIN32
Comment 1 OpenLDAP project 2019-06-04 20:55:30 UTC 
has patch
Comment 2 Quanah Gibson-Mount 2019-06-04 20:55:30 UTC 
changed notes