Issue 7309 - [PATCH] contrib/slapd-modules: Unify the structure and usage of Makefile
Summary: [PATCH] contrib/slapd-modules: Unify the structure and usage of Makefile
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: build (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-15 03:07 UTC by SATOH Fumiyasu
Modified: 2014-08-01 21:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description SATOH Fumiyasu 2012-06-15 03:07:25 UTC
Full_Name: SATOH Fumiyasu
Version: master, 2.4.31
OS: 
URL: https://gist.github.com/2931594
Submission from: (NULL) (114.48.132.80)


In contrib/slapd-modules, there are many Makefiles for each contrib
modules, but there is no common style and usage of Makefile.
E.g, some Makefile use $LDAP_SRC to specify a location of OpenLDAP
source tree but others use $LDAPSRC or $OPENLDAP_SRC.

I've created a patch to unify the structure and usage of Makefiles
in contrib/slapd-modules.
Comment 1 Howard Chu 2012-06-26 13:37:33 UTC
changed notes
changed state Open to Test
moved from Incoming to Build
Comment 2 Quanah Gibson-Mount 2012-12-10 22:36:41 UTC
changed notes
changed state Test to Release
Comment 3 Michael Ströder 2012-12-15 19:06:03 UTC
I've tested RE24 4aed59cafd4815ea9d849b0031ebab54a0d74536 with this build
patch applied and everything seems to work for me.

(Actually the patch was applied to RE24 in
979d48625035d7ccd85f0021295fc8ee0f45e31d.)


Comment 4 Quanah Gibson-Mount 2012-12-15 22:27:17 UTC
--On Saturday, December 15, 2012 7:06 PM +0000 michael@stroeder.com wrote:

> This is a cryptographically signed message in MIME format.
>
> --------------ms020502020407040509060800
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> I've tested RE24 4aed59cafd4815ea9d849b0031ebab54a0d74536 with this build=
>
> patch applied and everything seems to work for me.
>
> (Actually the patch was applied to RE24 in
> 979d48625035d7ccd85f0021295fc8ee0f45e31d.)

Thanks Michael!

--Quanah


--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Comment 5 Quanah Gibson-Mount 2013-03-05 02:17:21 UTC
changed notes
changed state Release to Closed
Comment 6 OpenLDAP project 2014-08-01 21:04:07 UTC
in master
in RE24