Issue 7291 - [PATCH] MozNSS: read pin from file file can cause infinite loop
Summary: [PATCH] MozNSS: read pin from file file can cause infinite loop
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 12:58 UTC by jvcelak@redhat.com
Modified: 2014-08-01 21:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jvcelak@redhat.com 2012-06-06 12:58:30 UTC
Full_Name: Jan Vcelak
Version: git master
OS: Linux
URL: ftp://ftp.openldap.org/incoming/jvcelak-20120606-moznss-read-pin-from-file-infinite-loop.patch
Submission from: (NULL) (209.132.186.34)


The buffer allocated for reading password (pin) file has to be initialized with
zeros, or we need to append zero at the end of the file. Otherwise we might read
initialized memory and consider it to be a password. In this situation, all
incoming TLS connections can hang.

Attached patch fixes this bug.

The attached file is derived from OpenLDAP Software. All of the modifications to
OpenLDAP Software represented in the following patch(es) were developed by Red
Hat. Red Hat has not assigned rights and/or interest in this work to any party.
I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under
the following terms. 

Red Hat hereby place the following modifications to OpenLDAP Software (and only
these modifications) into the public domain. Hence, these modifications may be
freely used and/or redistributed for any purpose with or without attribution
and/or other notice. 
Comment 1 jvcelak@redhat.com 2012-06-06 16:25:48 UTC
> might read initialized memory and consider it to be a password. In this

sorry, typo: uninitialized

Comment 2 Howard Chu 2012-06-07 12:06:01 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Bugs
Comment 3 Howard Chu 2012-06-07 12:07:04 UTC
jvcelak@redhat.com wrote:
>> might read initialized memory and consider it to be a password. In this
>
> sorry, typo: uninitialized

Thanks for the patch, committed to master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/


Comment 4 Quanah Gibson-Mount 2012-06-07 17:11:55 UTC
changed notes
changed state Test to Release
Comment 5 Quanah Gibson-Mount 2012-08-17 01:37:24 UTC
changed notes
changed state Release to Closed
Comment 6 OpenLDAP project 2014-08-01 21:04:43 UTC
fixed in master
fixed in RE24