Issue 7287 - [PATCH] MozNSS: do not overwrite error in tlsm_verify_cert
Summary: [PATCH] MozNSS: do not overwrite error in tlsm_verify_cert
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 09:53 UTC by jvcelak@redhat.com
Modified: 2014-08-01 21:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jvcelak@redhat.com 2012-06-05 09:53:49 UTC
Full_Name: Jan Vcelak
Version: git master
OS: Linux
URL: ftp://ftp.openldap.org/incoming/jvcelak-20120605-moznss-overwrite-error-in-tlsm-verify-cert.patch
Submission from: (NULL) (209.132.186.34)


If the peer certificate verification fails and the certificate does not contain
Basic Constraint Extension, wrong TLS error message is reported by the library.
In addition, TLS_REQCERT=never does not work in this situation. This is caused
by overwriting the original error code in tlsm_verify_cert() function.

Attached patch fixes this behavior.

Old version:

$ ldapsearch -x -ZZ
ldap_start_tls: Connect error (-11)
        additional info: TLS error -8157:Certificate extension not found.

Fixed version:

$ ldapsearch -x -ZZ
ldap_start_tls: Connect error (-11)
        additional info: TLS error -8172:Peer's certificate issuer has been
marked as not trusted by the user.


The attached file is derived from OpenLDAP Software. All of the modifications to
OpenLDAP Software represented in the following patch(es) were developed by Red
Hat. Red Hat has not assigned rights and/or interest in this work to any party.
I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under
the following terms. 

Red Hat hereby place the following modifications to OpenLDAP Software (and only
these modifications) into the public domain. Hence, these modifications may be
freely used and/or redistributed for any purpose with or without attribution
and/or other notice. 
Comment 1 Howard Chu 2012-06-05 10:45:02 UTC
jvcelak@redhat.com wrote:
> Full_Name: Jan Vcelak
> Version: git master
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/jvcelak-20120605-moznss-overwrite-error-in-tlsm-verify-cert.patch
> Submission from: (NULL) (209.132.186.34)
>
>
> If the peer certificate verification fails and the certificate does not contain
> Basic Constraint Extension, wrong TLS error message is reported by the library.
> In addition, TLS_REQCERT=never does not work in this situation. This is caused
> by overwriting the original error code in tlsm_verify_cert() function.
>
> Attached patch fixes this behavior.

Applied to master.
>
> Old version:
>
> $ ldapsearch -x -ZZ
> ldap_start_tls: Connect error (-11)
>          additional info: TLS error -8157:Certificate extension not found.
>
> Fixed version:
>
> $ ldapsearch -x -ZZ
> ldap_start_tls: Connect error (-11)
>          additional info: TLS error -8172:Peer's certificate issuer has been
> marked as not trusted by the user.
>
>
> The attached file is derived from OpenLDAP Software. All of the modifications to
> OpenLDAP Software represented in the following patch(es) were developed by Red
> Hat. Red Hat has not assigned rights and/or interest in this work to any party.
> I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under
> the following terms.
>
> Red Hat hereby place the following modifications to OpenLDAP Software (and only
> these modifications) into the public domain. Hence, these modifications may be
> freely used and/or redistributed for any purpose with or without attribution
> and/or other notice.
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/


Comment 2 Howard Chu 2012-06-05 10:45:56 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Bugs
Comment 3 Quanah Gibson-Mount 2012-06-05 16:38:12 UTC
changed notes
changed state Test to Release
Comment 4 Quanah Gibson-Mount 2012-08-17 01:37:09 UTC
changed notes
changed state Release to Closed
Comment 5 OpenLDAP project 2014-08-01 21:04:43 UTC
fixed in master
fixed in RE24