Full_Name: Jan Synacek Version: 2.4.29 OS: Fedora 16 URL: http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch Submission from: (NULL) (209.132.186.34) Constraint overlay doesn't take into account multiple modifications when using count. Example: If count for 'description' attribute is set e.g. to 2, the following results in a constraint violation: dn: cn=usr2, dc=my-domain,dc=com add: description description: d1 description: d2 description: d3-viol However, this passes: dn: cn=usr2, dc=my-domain,dc=com add: description description: d1 - add: description description: d2 - add: description description: d3 This patch fixes the behavior in case multiple modifications are used. Original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=742163 The patch is uploaded on fedorapeople.org: http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch I wasn't able to use ftp.openldap.org due to 'No space left' error. The attached file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Red Hat. Red Hat has not assigned rights and/or interest in this work to any party. I, Jan Synacek am authorized by Red Hat, my employer, to release this work under the following terms. Red Hat hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.
jsynacek@redhat.com wrote: > Full_Name: Jan Synacek > Version: 2.4.29 > OS: Fedora 16 > URL: http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch > Submission from: (NULL) (209.132.186.34) > > > Constraint overlay doesn't take into account multiple modifications when using > count. > > Example: If count for 'description' attribute is set e.g. to 2, the following > results in a constraint violation: > > dn: cn=usr2, dc=my-domain,dc=com > add: description > description: d1 > description: d2 > description: d3-viol > > However, this passes: > > dn: cn=usr2, dc=my-domain,dc=com > add: description > description: d1 > - > add: description > description: d2 > - > add: description > description: d3 > > This patch fixes the behavior in case multiple modifications are used. > > Original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=742163 > > The patch is uploaded on fedorapeople.org: > http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch > > I wasn't able to use ftp.openldap.org due to 'No space left' error. This code (and the original) don't seem to properly take deletes into account. It resets the ce counter to 0 on any delete op, but it should be decrementing based on the number of values provided. (And of course, it can only do that if the specified value is actually present in the attribute.) > The attached file is derived from OpenLDAP Software. All of the modifications > to > OpenLDAP Software represented in the following patch(es) were developed by Red > Hat. Red Hat has not assigned rights and/or interest in this work to any party. > I, Jan Synacek am authorized by Red Hat, my employer, to release this work > under > the following terms. > > Red Hat hereby place the following modifications to OpenLDAP Software (and only > these modifications) into the public domain. Hence, these modifications may be > freely used and/or redistributed for any purpose with or without attribution > and/or other notice. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
On 06/07/2012 03:00 PM, Howard Chu wrote: > jsynacek@redhat.com wrote: >> Full_Name: Jan Synacek >> Version: 2.4.29 >> OS: Fedora 16 >> URL: http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch >> Submission from: (NULL) (209.132.186.34) >> >> >> Constraint overlay doesn't take into account multiple modifications when using >> count. >> >> Example: If count for 'description' attribute is set e.g. to 2, the following >> results in a constraint violation: >> >> dn: cn=usr2, dc=my-domain,dc=com >> add: description >> description: d1 >> description: d2 >> description: d3-viol >> >> However, this passes: >> >> dn: cn=usr2, dc=my-domain,dc=com >> add: description >> description: d1 >> - >> add: description >> description: d2 >> - >> add: description >> description: d3 >> >> This patch fixes the behavior in case multiple modifications are used. >> >> Original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=742163 >> >> The patch is uploaded on fedorapeople.org: >> http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch >> >> I wasn't able to use ftp.openldap.org due to 'No space left' error. > > This code (and the original) don't seem to properly take deletes into account. It resets the ce counter to 0 on any delete op, but it should be decrementing based on the number of values provided. (And of course, it can only do that if the specified value is actually present in the attribute.) I'll fix the patch. I tested only deletes with no additional values. -- Jan Synacek Software Engineer, BaseOS team Brno, Red Hat
On 06/07/2012 03:00 PM, Howard Chu wrote: > jsynacek@redhat.com wrote: >> Full_Name: Jan Synacek >> Version: 2.4.29 >> OS: Fedora 16 >> URL: http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch >> Submission from: (NULL) (209.132.186.34) >> >> >> Constraint overlay doesn't take into account multiple modifications when using >> count. >> >> Example: If count for 'description' attribute is set e.g. to 2, the following >> results in a constraint violation: >> >> dn: cn=usr2, dc=my-domain,dc=com >> add: description >> description: d1 >> description: d2 >> description: d3-viol >> >> However, this passes: >> >> dn: cn=usr2, dc=my-domain,dc=com >> add: description >> description: d1 >> - >> add: description >> description: d2 >> - >> add: description >> description: d3 >> >> This patch fixes the behavior in case multiple modifications are used. >> >> Original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=742163 >> >> The patch is uploaded on fedorapeople.org: >> http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint-count.patch >> >> I wasn't able to use ftp.openldap.org due to 'No space left' error. > > This code (and the original) don't seem to properly take deletes into account. It resets the ce counter to 0 on any delete op, but it should be decrementing based on the number of values provided. (And of course, it can only do that if the specified value is actually present in the attribute.) > I've updated the patch: http://jsynacek.fedorapeople.org/openldap/jsynacek-20120619-constraint-count.patch Also, I've uploaded the tests I use: http://jsynacek.fedorapeople.org/openldap/constraint-count-tests.tar.bz2 -- Jan Synacek Software Engineer, BaseOS team Brno, Red Hat
Jan Synacek wrote: > On 06/07/2012 03:00 PM, Howard Chu wrote: >> This code (and the original) don't seem to properly take deletes into account. It resets the ce counter to 0 on any delete op, but it should be decrementing based on the number of values provided. (And of course, it can only do that if the specified value is actually present in the attribute.) > I've updated the patch: > http://jsynacek.fedorapeople.org/openldap/jsynacek-20120619-constraint-count.patch Thanks, committed to master with additional tweaks. > > Also, I've uploaded the tests I use: > http://jsynacek.fedorapeople.org/openldap/constraint-count-tests.tar.bz2 Looks like a nice start but you should look at the existing test script infrastructure, particularly the shell variables we already define, and make it conform. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
changed notes changed state Open to Test moved from Incoming to Software Bugs
changed notes changed state Test to Partial
changed notes changed state Partial to Open
--On Tuesday, June 19, 2012 5:19 AM +0000 jsynacek@redhat.com wrote: > On 06/07/2012 03:00 PM, Howard Chu wrote: >> jsynacek@redhat.com wrote: >>> Full_Name: Jan Synacek >>> Version: 2.4.29 >>> OS: Fedora 16 >>> URL: >>> http://jsynacek.fedorapeople.org/openldap/jsynacek-20120216-constraint- >>> count.patch Submission from: (NULL) (209.132.186.34) >>> This patch is broken. See ITS#7340 and discussion on -technical. --Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration
changed notes
changed notes changed state Open to Release
changed notes changed state Release to Closed
Fixed in head Fixed in RE24