OpenLDAP
Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest

Viewing Archive.Development/2630
Full headers

From: eikemeier@fillmore-labs.com
Subject: declarations missing in libraries/liblunicode/ucstr.c
Compose comment
Download message
State:
1 replies: 1
1 followups: 1

Major security issue: yes  no

Notes:

Notification:


Date: Sat, 5 Jul 2003 10:10:22 GMT
From: eikemeier@fillmore-labs.com
To: openldap-its@OpenLDAP.org
Subject: declarations missing in libraries/liblunicode/ucstr.c
Full_Name: Oliver Eikemeier
Version: 2.2.0alpha
OS: FreeBSD
URL: 
Submission from: (NULL) (80.128.179.49)


The prototypes of
  ber_dupbv_x
  ber_memalloc_x
are missing in libraries/liblunicode/ucstr.c, implicitly declaring them
as 'int'. This results in warings during the build:
  ucstr.c: In function `UTF8bvnormalize':
  ucstr.c:118: warning: return makes pointer from integer without a cast
  ucstr.c:150: warning: return makes pointer from integer without a cast
  ucstr.c:171: warning: assignment makes pointer from integer without a cast
  ucstr.c: In function `UTF8bvnormcmp':
  ucstr.c:353: warning: assignment makes pointer from integer without a cast
  ucstr.c:376: warning: assignment makes pointer from integer without a cast
and looks like the reson for the core dump on 64 bit platforms:
 <http://www.openldap.org/lists/openldap-software/200307/msg00170.html>

Fix:

--- libraries::liblunicode::ucstr.c.patch begins here ---
--- libraries/liblunicode/ucstr.c.orig	Fri Apr 11 03:57:10 2003
+++ libraries/liblunicode/ucstr.c	Sat Jul  5 10:53:04 2003
@@ -15,6 +15,8 @@
 #include <ldap_utf8.h>
 #include <ldap_pvt_uc.h>
 
+#include "lber_pvt.h"
+
 #define	malloc(x)	ber_memalloc_x(x,ctx)
 #define	realloc(x,y)	ber_memrealloc_x(x,y,ctx)
 #define	free(x)		ber_memfree_x(x,ctx)
--- libraries::liblunicode::ucstr.c.patch ends here ---


Followup 1

Download message
Date: Sun, 06 Jul 2003 01:46:01 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: Kurt Zeilenga <openldap-its@OpenLDAP.org>
Subject: Re: declarations missing in libraries/liblunicode/ucstr.c (ITS#2630)
Kurt Zeilenga wrote:

> Already fixed in HEAD.

sorry, I promise to look into CVS next time.

Thanks for the quick reply
    Oliver




Reply 1

Resend
From: Kurt Zeilenga <openldap-its@OpenLDAP.org>
To: eikemeier@fillmore-labs.com
Subject: Re: declarations missing in libraries/liblunicode/ucstr.c (ITS#2630)
Date: Sat Jul  5 23:25:50 2003
Already fixed in HEAD.

Kurt

Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest


The OpenLDAP Issue Tracking System uses a hacked version of JitterBug

______________
© Copyright 2013, OpenLDAP Foundation, info@OpenLDAP.org