Issue 2630 - declarations missing in libraries/liblunicode/ucstr.c
Summary: declarations missing in libraries/liblunicode/ucstr.c
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-05 10:10 UTC by eikemeier@fillmore-labs.com
Modified: 2014-08-01 21:05 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description eikemeier@fillmore-labs.com 2003-07-05 10:10:22 UTC
Full_Name: Oliver Eikemeier
Version: 2.2.0alpha
OS: FreeBSD
URL: 
Submission from: (NULL) (80.128.179.49)


The prototypes of
  ber_dupbv_x
  ber_memalloc_x
are missing in libraries/liblunicode/ucstr.c, implicitly declaring them
as 'int'. This results in warings during the build:
  ucstr.c: In function `UTF8bvnormalize':
  ucstr.c:118: warning: return makes pointer from integer without a cast
  ucstr.c:150: warning: return makes pointer from integer without a cast
  ucstr.c:171: warning: assignment makes pointer from integer without a cast
  ucstr.c: In function `UTF8bvnormcmp':
  ucstr.c:353: warning: assignment makes pointer from integer without a cast
  ucstr.c:376: warning: assignment makes pointer from integer without a cast
and looks like the reson for the core dump on 64 bit platforms:
 <http://www.openldap.org/lists/openldap-software/200307/msg00170.html>

Fix:

--- libraries::liblunicode::ucstr.c.patch begins here ---
--- libraries/liblunicode/ucstr.c.orig	Fri Apr 11 03:57:10 2003
+++ libraries/liblunicode/ucstr.c	Sat Jul  5 10:53:04 2003
@@ -15,6 +15,8 @@
 #include <ldap_utf8.h>
 #include <ldap_pvt_uc.h>
 
+#include "lber_pvt.h"
+
 #define	malloc(x)	ber_memalloc_x(x,ctx)
 #define	realloc(x,y)	ber_memrealloc_x(x,y,ctx)
 #define	free(x)		ber_memfree_x(x,ctx)
--- libraries::liblunicode::ucstr.c.patch ends here ---

Comment 1 Kurt Zeilenga 2003-07-05 23:25:50 UTC
Already fixed in HEAD.

Kurt
Comment 2 Kurt Zeilenga 2003-07-05 23:26:02 UTC
changed notes
changed state Open to Closed
moved from Incoming to Development
Comment 3 eikemeier@fillmore-labs.com 2003-07-05 23:46:01 UTC
Kurt Zeilenga wrote:

> Already fixed in HEAD.

sorry, I promise to look into CVS next time.

Thanks for the quick reply
    Oliver


Comment 4 Howard Chu 2009-02-17 06:52:54 UTC
moved from Development to Archive.Development
Comment 5 OpenLDAP project 2014-08-01 21:05:18 UTC
already fixed