Viewing Archive.Software Enhancements/170
Full headers

Major security issue: yes  no

Notes:
See devel codes.
Notification:

Date: Thu, 20 May 1999 08:54:49 GMT
From: webmaster@access.ch
To: openldap-its@OpenLDAP.org
Subject: Patch for enabling Multi Master servers

Full_Name: Philipp Klaus
Version: 1.2.1
OS: Linux
URL: http://www.internet.access.ch/openldap/ldap_multimaster.patch
Submission from: (NULL) (195.112.64.100)


OpenLDAP release 1.2.1 wasn't able to handle situations where multi servers
must
accept write statements and distribute them to all other servers (for failover
capabilities in write commands too).

A quick look at the code showed that for each change (add, delete, modify)
command a
record is written to the replica log file if a replica statement exists in the 
configuration file. I changed this so that the log file record is only written
if 
the write command was NOT submitted by the replication user.
This has the drawback that multi-level replication isn't possible anymore but
this
is of no value for me because the replication is only used for enabling high
availability (clustering) on our site.

All changes are ifdef'ed by _INA_MULTI_MASTER so compiling without the changes
is
still possible.

I suggest including the patch with the (probably renamed) ifdefs in place so
that the
multi-master capabilities are a compile time option.

All code is given to the open source community free of charge.

Followup 1

Date: Tue, 08 Jun 1999 08:22:13 +0200
From: Philipp Klaus <webmaster@access.ch>
To: openldap-its@openldap.org
Subject: ITS#170

I applied my patch against OpenLDAP 1.2.3 and made new diffs which I put
online under the following URL:

http://www.internet.access.ch/openldap/ldap_patch-1.2.3_mm

I had to change a few lines because the update of the modifytimestamp
and modifiersname attributes aren't still in modify.c but in the
corresponding file in the ldbm backend (why is the creator code in add.c
and not in the ldbm backend too?).

I haven't updated our production environment yet (never touch a running
system) but as soon as I found the time to do a little testing on my
development machine I will update the first few systems to see how the
new version works under heavy load.

Philipp

Reply 1

From: Kurt Zeilenga <kurt@OpenLDAP.org>
To: webmaster@access.ch
Subject: Re: Patch for enabling Multi Master servers (ITS#170)
Date: Tue Aug  3 20:27:56 1999

Applied updated patch to devel with a few minimal modifications
plus configuration support (--enable-multimaster).  Please test.

TODO: update replication test to work in both single- and multi-
master environments.

Kurt

Reply 2

From: Hallvard B Furuseth <openldap-its@OpenLDAP.org>
To: webmaster@access.ch
Subject: Re: Patch for enabling Multi Master servers (ITS#170)
Date: Mon Sep  6 01:46:33 1999

Multimaster support breaks 'make test' in -devel.
Please check if <URL:http://www.katalog.uninett.no/ldap/mm.patch>
fixes it, and if multimaster support still works as you want it.

Changes:
- Don't do lastmod updates if the operation comes from
  the the updatedn user (op->o_ndn === be->be_update_ndn).
- The lastmod test in add.c was misplaced.

-- 
Hallvard